Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Restores decorative dividers beside sidebar counts and workflow phase details. The change is visual-only, preserving interaction behavior, accessibility attributes, and theme colors. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Keep the header rule visible apps/web/src/components/ui/collapsible-section-header.tsx |
The rule no longer gets the invisible class when an accessory is present. The explanatory comment was removed. |
Priority:
Estimated code review effort: 1 (Trivial) | ~4 minutes
Change: Bug fix · Severity of issue fixed: Low
Possibly related PRs
- pingdotgg/t3code#24865: Changed the same header rule’s visibility when a collapsed section has an accessory.
- pingdotgg/t3code#25251: Changed the same rule’s visibility classes based on the accessory and expanded state.
- pingdotgg/t3code#24837: Introduced accessory-based divider hiding in
CollapsibleSectionHeader.
Suggested labels: bugfix, size:XS
Suggested reviewers: t3dotgg
Merge Risk: 
Minimal · up to ea1c1
-
The focused visual fix is mergeable with no outstanding review risks.
Pre-merge checks: 
4
-
Full details: Title check
-
Explanation
The title names the fix (restoring dividers) and the area it touches (sidebar section counts), which matches the change. The raw summary shows the accessory-based hiding condition was removed so the horizontal rule stays visible. The title follows the conventional commit format and is specific. The description notes the same component also affects workflow phase headers, which the title does not mention, but that is a secondary effect and does not make the title misleading.
Full details: Description check
-
Explanation
The description covers the problem (sidebar lost dividers during the redesign), the change (removes the condition hiding the divider when an accessory is present), and verification (validation commands listed, before/after screenshots embedded, no new tests explained for a CSS-only change). It does not follow the template's Scope and approval section: it links no triaged issue or maintainer-approved discussion and gives no justification for skipping one. The Problem and Change headings are present in content form but not as the template headings. The check still passes because the description is mostly complete and the missing approval link is a process gap rather than a content gap for this small fix.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
Note Written by Verified in a real dev environmentverified as-is at
before, expanded shelves (main): after, same threads and counts (pr; elapsed labels advance naturally): short runtime transcript: Not verified
|




the sidebar lost the bars between Working / Snoozed / Settled and their counts during the redesign. this restores the earlier divider span by removing the condition that hides it when an accessory is present, keeping the current theme colors.
this also restores dividers in workflow phase headers, which use the same component.
captures use the real component and app stylesheet in an isolated fixture, with expanded headers above collapsed headers. hosted externally because the available GitHub browser profiles are signed out.
validation:
vp run check:changedpassed, including formatting, lint, both knip passes, and typecheck of the web and scripts packages. no new tests for this CSS-only change.written with gpt-6.1-sol in T3 Code through the Codex harness.