Skip to content

fix(web): restore dividers beside sidebar section counts - #26403

Open
Microck wants to merge 1 commit into
pingdotgg:mainfrom
Microck:fix/sidebar-section-dividers
Open

Microck wants to merge 1 commit into
pingdotgg:mainfrom
Microck:fix/sidebar-section-dividers

Conversation

@Microck

@Microck Microck commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

the sidebar lost the bars between Working / Snoozed / Settled and their counts during the redesign. this restores the earlier divider span by removing the condition that hides it when an accessory is present, keeping the current theme colors.

this also restores dividers in workflow phase headers, which use the same component.

before after
before after

captures use the real component and app stylesheet in an isolated fixture, with expanded headers above collapsed headers. hosted externally because the available GitHub browser profiles are signed out.

validation: vp run check:changed passed, including formatting, lint, both knip passes, and typecheck of the web and scripts packages. no new tests for this CSS-only change.

written with gpt-6.1-sol in T3 Code through the Codex harness.

@github-actions github-actions Bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Oct 28, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ea1c1e8

Macroscope's review found this PR approvable — Restores decorative dividers beside sidebar counts and workflow phase details. The change is visual-only, preserving interaction behavior, accessibility attributes, and theme colors.

You can add or adjust custom eligibility rules. Learn more.

@github-actions github-actions Bot added the size:XS 0-9 changed lines (additions + deletions). label Oct 28, 2026
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 2a73827 and ea1c1e8.

Files selected for processing: 1
  • apps/web/src/components/ui/collapsible-section-header.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The collapsible section header keeps its horizontal rule visible when an accessory is present. The comment describing the previous hiding condition was removed.

Changes: Divider visibility

Layer / File(s) Summary
Keep the header rule visible
apps/web/src/components/ui/collapsible-section-header.tsx
The rule no longer gets the invisible class when an accessory is present. The explanatory comment was removed.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related PRs

Suggested labels: bugfix, size:XS

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to ea1c1

The focused visual fix is mergeable with no outstanding review risks.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title names the fix (restoring dividers) and the area it touches (sidebar section counts), which matches the change. The raw summary shows the accessory-based hiding condition was removed so the h…
Description check Passed The description covers the problem (sidebar lost dividers during the redesign), the change (removes the condition hiding the divider when an accessory is present), and verification (validation command…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the fix (restoring dividers) and the area it touches (sidebar section counts), which matches the change. The raw summary shows the accessory-based hiding condition was removed so the horizontal rule stays visible. The title follows the conventional commit format and is specific. The description notes the same component also affects workflow phase headers, which the title does not mention, but that is a secondary effect and does not make the title misleading.

Full details: Description check

Explanation

The description covers the problem (sidebar lost dividers during the redesign), the change (removes the condition hiding the divider when an accessory is present), and verification (validation commands listed, before/after screenshots embedded, no new tests explained for a CSS-only change). It does not follow the template's Scope and approval section: it links no triaged issue or maintainer-approved discussion and gives no justification for skipping one. The Problem and Change headings are present in content form but not as the template headings. The check still passes because the description is mostly complete and the missing approval link is a process gap rather than a content gap for this small fix.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

maria-rcks commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified as-is at ea1c1e8bee48869240408af4dcafdde90c96c800. no source changes or pushes.

  • reproduced on github/main (5ef56853ef1854da50bc1909c6c0a32700f2cb13) in a separate worktree after vp i. working, snoozed and settled headers all hid their divider beside the count.
  • installed the exact pr head with vp i, stopped main's captured process group, and ran one background vp run dev --home-dir /home/user/t3code/.t3. actual ports: web 5733, server 13773.
  • drove the real web client using the repo's playwright dependency and /usr/bin/google-chrome. added the real git project through the app, created threads and ran codex gpt-6.1-sol turns through the local proxy. no mocks, fixtures or demo data. copied only the isolated, app-created state after stopping main for matching before/after data.
  • on the pr, all three dividers remain visible while expanding and collapsing shelves during a real provider turn. counts and chevrons remain aligned. checked light at 1440×1000 and dark at 1440×1000 and 1100×800.
  • checked neighboring behavior: wake removed the snoozed shelf at zero; re-snooze restored count 1. settling changed settled 1→2; un-settling restored 1. the real codex tool call completed and its reply rendered in the client.
  • inspected the captures and played the uploaded 10-second mp4 through to the end and sought within it. the inline gif contains the same recording. a fresh github read reports 24 successful and 6 skipped contexts, with none failing or pending; no new source checks were run because this verification made no code changes.

before, expanded shelves (main):

main: snoozed and settled counts without dividers

after, same threads and counts (pr; elapsed labels advance naturally):

pr: snoozed and settled counts with restored dividers

pr: expanding and collapsing working, snoozed and settled during a real codex turn

pr: real codex reply rendered in the dark-theme client

short runtime transcript:

main: Working1 / Snoozed1 / Settled1 -> divider visibility: hidden
pr:   Working1 / Snoozed1 / Settled1 -> divider visibility: visible
web composer -> codex gpt-6.1-sol -> timeout 60 sleep 45
provider turn -> completed, error=null
client reply -> "real codex sidebar check passed."
wake -> Snoozed0 (shelf removed); re-snooze -> Snoozed1
settle -> Settled2; un-settle -> Settled1

Not verified

  • the shared component's claude workflow phase header path. these runs used codex; no claude workflow was launched, so its phase counters, failed status and elapsed accessory are unverified.
  • native electron, ios and android clients; macos/windows-specific rendering; relay/tunnel and multi-device connections. this pass exercised the linux web client against the running local server.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants